feat(pulsar-functions): add FQFN support and optional parameters#77
Merged
feat(pulsar-functions): add FQFN support and optional parameters#77
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Fully Qualified Function Name (FQFN) support and numerous optional parameters to the Pulsar Functions tool, significantly enhancing its flexibility and usability.
Changes:
- Introduces FQFN format (
tenant/namespace/name) as an alternative to specifying tenant, namespace, and name separately - Makes tenant and namespace optional with sensible defaults (
publicanddefault) - Adds 50+ optional parameters for comprehensive function configuration including resource limits, windowing, secrets, serialization, and more
- Adds support for per-instance stats/status queries via
instanceIdparameter - Adds
triggerFileas an alternative totriggerValuefor trigger operations - Adds YAML config file support via
functionConfigFileparameter
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/mcp/builders/pulsar/functions.go | Core implementation adding FQFN parsing, parameter handling, validation logic, and helper functions |
| pkg/mcp/builders/pulsar/functions_parity_test.go | Unit tests for FQFN parsing, validation, and update argument checking |
| docs/tools/pulsar_admin_functions.md | Documentation updates reflecting new optional parameters and FQFN support |
| cmd/snmcp-e2e/main.go | E2E test additions covering function create, update, trigger, and delete operations |
| cmd/snmcp-e2e/testdata/functions/echo.py | Simple Python echo function for E2E testing |
| Dockerfile | Adds echo.py to Docker image for E2E test availability |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jiangpengcheng
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.